Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css_fire #74

Closed
wants to merge 20 commits into from
Closed

css_fire #74

wants to merge 20 commits into from

Conversation

P250
Copy link
Contributor

@P250 P250 commented Mar 6, 2024

  • Support for css_fire (with @css/generic permission required)
  • Integrates with peacemute i.e. if warden has peacemute active and is fired, the peacemute is also revoked

MSWS and others added 19 commits February 10, 2024 14:29
@MSWS
Add team switch listener, fix log assignment (#40) (#41)
01d159a
css_peace / first warden assigned mute
decf532
added css_peace command cooldown / code cleanup
f666467
@MSWS
Add perm check and autobalance bypass
977fbb7
@MSWS
Add perm check and autobalance bypass (#70)
97123e9
@MSWS
Add more info to join msg
9af8d2d
@MSWS
Add more info to join msg (#71)
e8c5e20
css_peace cooldown added\nrevamped half of the system\nadded a flag c…
b2fc6bd 
…heck (for muted players) which does nothing if not set by admin\nadded notification support for whole peace system\ncleanup some random code\nhandled most edge cases I can think of\n TODO handle unmuting players after warmup ends
API documentation
2fa50af
readonly on notification classes prefixes
4c5d809
@MSWS
Allow anyone on CT
0fb218e
@MSWS
Allow anyone on CT (#72)
8d8f2dc
@MSWS
Uncap prisoners
ccc2dc4
@MSWS
Uncap prisoners (#73)
402ee13
Code overhaul
1981bfa 
Fixed lots of logic errors

Added listeners for when players leave/join server to handle muting of those players

Please read todo comments (note to self)
remove code repetition
b048cf4
fix
535ccdf
more logic fixes..
fa4c17d
css_fire command
3292d9a 
integrates with peacemute, if warden is fired then peacemute expires
@Spock8901
Copy link

will this work when an admin is forced to use the command?

@P250
Copy link
Contributor Author

P250 commented Mar 7, 2024

will this work when an admin is forced to use the command?

I’ve tested it alone and the warden was indeed fired, and they need the @css/generic permission. I’m not sure what else you mean :)

@Spock8901
Copy link

will this work when an admin is forced to use the command?

I’ve tested it alone and the warden was indeed fired, and they need the @css/generic permission. I’m not sure what else you mean :)

oh wait thought it said peace sry 6 hours ago i woke up at that time

@Mooshua
Copy link
Contributor

Mooshua commented Mar 8, 2024

This is a pretty big PR @P250. Did you mean to do commit all of this?
No worries if so, just going to take a bit to review.

@Mooshua Mooshua added type::3 Feature Feature - New addition that is not currently in production status::4 Testing Testing - Development has been generally completed and now needs dev testing labels Mar 8, 2024
@Mooshua Mooshua changed the base branch from main to dev March 8, 2024 19:06
@Mooshua
Copy link
Contributor

Mooshua commented Mar 8, 2024

In case you aren't aware. Every time you using static to prettify a static field access a cute puppy dies a painful death. (No change needed)

@Mooshua
Copy link
Contributor

Mooshua commented Mar 8, 2024 •
edited
Loading

@P250 If you're okay with it, I'd like to retarget this into a feature branch to do some refactorings around the event system you've got. I agree it's somewhat needed I just want it to be more servicecollection-oriented.

Submitted some minor change requests in the review. Haven't finished reviewing the timer shenanigans or the big changes.
Thanks for your time! This is great work.

@Mooshua Mooshua added this to the 1.1 milestone Mar 8, 2024
@Mooshua Mooshua mentioned this pull request Mar 8, 2024
Closed
@P250
Copy link
Contributor Author

P250 commented Mar 8, 2024

This is a pretty big PR @P250. Did you mean to do commit all of this? No worries if so, just going to take a bit to review.

Yes, I realised I kinda messed up by not committing smaller changes. Sorry about that.

@MSWS
Copy link
Contributor

MSWS commented Mar 24, 2024

Will be closing this PR due to the (unnecessary) size of it. Please feel free to clean it up and only PR what actually needs to be changed for a css_fire command.

@MSWS MSWS closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status::4 Testing Testing - Development has been generally completed and now needs dev testing type::3 Feature Feature - New addition that is not currently in production
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@P250 @Spock8901 @Mooshua @MSWS